Skip to content

TFRecordIOSchemaTransformProviderTest - fix race condition#36590

Closed
derrickaw wants to merge 7 commits intoapache:masterfrom
derrickaw:fixTFRecordDataRace
Closed

TFRecordIOSchemaTransformProviderTest - fix race condition#36590
derrickaw wants to merge 7 commits intoapache:masterfrom
derrickaw:fixTFRecordDataRace

Conversation

@derrickaw
Copy link
Copy Markdown
Collaborator

@derrickaw derrickaw commented Oct 22, 2025 •
edited
Loading

  1. Found a race condition in the TFRecordIOSchemaTransformProviderTests involving GZIP.
  2. GzipCompressorInputStream is not thread safe.

b/444196196

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the java label Oct 22, 2025
@derrickaw
Copy link
Copy Markdown
Collaborator Author

derrickaw commented Oct 24, 2025

Run Java PreCommit

@derrickaw
Copy link
Copy Markdown
Collaborator Author

derrickaw commented Oct 24, 2025

Run Java_IOs_Direct PreCommit

@derrickaw derrickaw marked this pull request as ready for review October 24, 2025 15:03
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 24, 2025

Assigning reviewers:

R: @ahmedabu98 for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 1, 2025

Reminder, please take a look at this pr: @ahmedabu98

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 5, 2025

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 12, 2025

Reminder, please take a look at this pr: @kennknowles

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 14, 2025

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @ahmedabu98 for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@kennknowles
Copy link
Copy Markdown
Member

kennknowles commented Nov 14, 2025

I'm taking a look at this. I'm taking it slow, because I don't think this class should be accessed concurrently. In other words, the thread safety should be ensured at a higher level, at a coarser granularity.

@derrickaw
Copy link
Copy Markdown
Collaborator Author

derrickaw commented Nov 17, 2025

Closing since this seems to a be a timeout issue that is causing the race condition. When running longer to completion, no race conditions are seen.

@derrickaw derrickaw closed this Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

java Next Action: Reviewers reassigned-reviewers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@derrickaw @kennknowles